Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document graceful-shutdown-timeout flag #1316

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

relu
Copy link
Member

@relu relu commented Dec 9, 2022

Adding documentation for the new --graceful-shutdown-timeout flag.

@relu relu force-pushed the hc-graceful-shutdown-timeout-flag-docs branch from c0f747c to 66699fe Compare December 9, 2022 11:56
@relu relu requested a review from stefanprodan December 9, 2022 11:56
@stefanprodan stefanprodan marked this pull request as draft December 9, 2022 12:23
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

⚠️ Please hold this until the next helm-controller release

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@relu relu force-pushed the hc-graceful-shutdown-timeout-flag-docs branch from 66699fe to 9fc76ad Compare December 20, 2022 15:27
Adding documentation for the new `--graceful-shutdown-timeout` flag.

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu force-pushed the hc-graceful-shutdown-timeout-flag-docs branch from 9fc76ad to 24b37bb Compare December 20, 2022 15:30
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@stefanprodan stefanprodan marked this pull request as ready for review December 21, 2022 09:57
@stefanprodan stefanprodan merged commit b576d58 into main Dec 21, 2022
@stefanprodan stefanprodan deleted the hc-graceful-shutdown-timeout-flag-docs branch December 21, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants