libgit2: correctly resolve (annotated) tags #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
libgit2-simple-tag
branch
3 times, most recently
from
b484454 to
86d7326
Compare
hiddeco
added
area/git
hiddeco
force-pushed
the
libgit2-simple-tag
branch
from
86d7326 to
39e1d40
Compare
hiddeco
force-pushed
the
libgit2-simple-tag
branch
2 times, most recently
from
4dcf7b2 to
e988f90
Compare
In d0560e5 the SemVer implementations were aligned, and the logic was simplified a bit (or so I thought). This did however result in the introduction of a regression, as it failed to take "simple tags" into account. This commit ensures both are taken into account again, and ensures it is now covered by a proper test. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
libgit2-simple-tag
branch
from
e988f90 to
e736493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d0560e5 the SemVer implementations were aligned, and the logic was
simplified a bit (or so I thought). This did however result in the
introduction of a regression, as it failed to take "simple tags" into
account.
This commit ensures both are taken into account again, and ensures it
is now covered by a proper test.
Fixes: #456