Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: rename OCIChartRepository.insecure to insecureHTTP #1299

Merged
merged 1 commit into from
Nov 30, 2023
Merged

oci: rename OCIChartRepository.insecure to insecureHTTP #1299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/helm/repository/oci_chart_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ type OCIChartRepository struct {
// verifiers is a list of verifiers to use when verifying a chart.
verifiers []oci.Verifier

// insecureHTTP indicates that the chart is hosted on an insecure registry.
insecure bool
// insecureHTTP indicates that the chart is hosted on an insecure HTTP registry.
insecureHTTP bool
}

// OCIChartRepositoryOption is a function that can be passed to NewOCIChartRepository
Expand All @@ -94,7 +94,7 @@ func WithVerifiers(verifiers []oci.Verifier) OCIChartRepositoryOption {

func WithInsecureHTTP() OCIChartRepositoryOption {
return func(r *OCIChartRepository) error {
r.insecure = true
r.insecureHTTP = true
return nil
}
}
Expand Down Expand Up @@ -369,7 +369,7 @@ func (r *OCIChartRepository) VerifyChart(ctx context.Context, chart *repo.ChartV
}

var nameOpts []name.Option
if r.insecure {
if r.insecureHTTP {
nameOpts = append(nameOpts, name.Insecure)
}

Expand Down