sourceignore: make a copy of domain for pattern #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
ignore-pattern-domain-side-effect
branch
from
6fd0140 to
7f650b5
Compare
LoadIgnorePatterns() modified the domain string slice after creating ignore pattern, due to which the domain of certain patterns created below the first directory level with multiple directories at the same level resulted in the patterns to have the domain of the last directory in the same directory level. This is fixed by making a copy of the domain before creating a pattern. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
ignore-pattern-domain-side-effect
branch
from
7f650b5 to
1cf9c3b
Compare
darkowlzz
commented
Mar 15, 2023
| @@ -222,7 +224,7 @@ func TestLoadExcludePatterns(t *testing.T) { | |||
| name: "traverse loads", | |||
| dir: tmpDir, | |||
| want: []gitignore.Pattern{ | |||
| gitignore.ParsePattern("root.txt", nil), | |||
| gitignore.ParsePattern("root.txt", []string{}), | |||
There was a problem hiding this comment.
With the copied domain, the DeepEqual below fails when this domain is nil, even though all the components of the pattern are exactly the same.
hiddeco
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadIgnorePatterns()modified the domain string slice after creating ignore pattern, due to which the domain of certain patterns created below the first directory level with multiple directories at the same level resulted in the patterns to have the domain of the last directory in the same directory level.This is fixed by making a copy of the domain before creating a pattern.
Refer https://yourbasic.org/golang/gotcha-append/ for details about this side effect of appending slices.
Refer https://github.com/hiddeco/proof/tree/different-tree for an example repository to reproduce this issue.
podinfo2/.sourceignorecontains*.Without the fix, the artifact contains
With the fix, the artifact contains