Progressive status helper and in-progress status checker #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
the
area/runtime
pjbgf
reviewed
Dec 5, 2022
darkowlzz
force-pushed
the
intermediate-conditions-summary
branch
from
fa89d27 to
3f943b7
Compare
stefanprodan
approved these changes
Dec 6, 2022
darkowlzz
force-pushed
the
intermediate-conditions-summary
branch
from
3f943b7 to
c007d73
Compare
hiddeco
reviewed
Dec 20, 2022
darkowlzz
force-pushed
the
intermediate-conditions-summary
branch
2 times, most recently
from
0e24dd3 to
4aa0603
Compare
hiddeco
approved these changes
Jan 9, 2023
Add a progressive status helper for setting the Reconciling and Ready conditions in the middle of reconciliation with consideration for drift detection. Signed-off-by: Sunny <darkowlzz@protonmail.com>
InProgressChecker is a variant of the status conditions checker with a different set of checks that are applicable to the objects in the middle of on-going reconciliation, with intermediate conditions. Delete invalid check FAIL0010. Add FAIL0011 for mid-reconciliation scenario. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
intermediate-conditions-summary
branch
from
4aa0603 to
7962d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a helper and a checker for progressive status of objects that are undergoing reconciliation. Progressive status are the status conditions that appear on an object in the middle of a reconciliation, also referred as mid-reconciliation status in this change.
ReconcilingandReadyare primarily involved in progressive status to indicate that an object is undergoing reconciliation.Reconciling=TrueandReady=Unknownare expected on the object.Ready=Trueset by a previous reconciliation, theReconciling=TruewithReady=Trueindicates that the reconciler is reconciling an object but hasn't detected any drift to act upon.Ready=Unknownindicates that there may be some drift for which the reconciler is performing some action.ProgressiveStatus helper
For working with the above scenarios of progressive status, a helper
ProgressiveStatus(drift, obj, reason, msg, msgArgs...)is introduced. It helps mark an objectReconciling=Trueand alsoReady=Unknownwith the same reason and message if a drift is detected. If no drift is detected, onlyReconciling=Trueis set.In-progress status checker
The progressive status conditions of an object are observed to be orthogonal to the final status of the object after a full reconciliation that's computed by various status summarization techniques. During a reconciliation, there's not enough information to perform full summarization of the status conditions. The partial information is sufficient to only report the current status of reconciliation in the form of progressive status. This results in differences in the considerations of status conditions check on an object. Due to this, the WARN and FAIL checks of the status checker have been updated to indicate if they apply to mid-reconciliation status or not. And a new check is added that's specific to mid-reconciliation status.
Due to the different sets of checks, a new in-progress status checker is introduced, which can be created with
NewInProgressChecker(). With this, we have two separate status checkers which can be used to check the progressive status and fully reconciled status of an object.Fixes #380