Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Digest of Artifact #818

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Verify Digest of Artifact #818

merged 1 commit into from
Mar 27, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 24, 2023

This commit changes the verification to the Digest field of the Artifact, which was introduced in source-controller v0.35.0. As the Checksum is expected to be removed in the next release of the source-controller.

@hiddeco hiddeco changed the title controllers: Verify Digest of Artifact Verify Digest of Artifact Mar 24, 2023
@hiddeco hiddeco added the enhancement New feature or request label Mar 24, 2023
@hiddeco hiddeco force-pushed the artifact-verify-digest branch 2 times, most recently from 9da4652 to e8951df Compare March 27, 2023 07:32
This commit changes the verification to the `Digest` field of the
Artifact, which was introduced in source-controller v0.35.0. As the
`Checksum` is expected to be removed in the next release of the
source-controller.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the artifact-verify-digest branch from e8951df to de3406b Compare March 27, 2023 10:50
@hiddeco hiddeco marked this pull request as ready for review March 27, 2023 10:50
@hiddeco hiddeco requested a review from stefanprodan March 27, 2023 11:04
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco merged commit af859b0 into main Mar 27, 2023
@hiddeco hiddeco deleted the artifact-verify-digest branch March 27, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants