Use the dynamic RESTMapper from controller-runtime v0.19 #1377
+2,782
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
lazy-restmapper
branch
from
eba0a71 to
76c3f94
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
lazy-restmapper
branch
from
76c3f94 to
8b6f4bc
Compare
matheuscscp
approved these changes
Feb 25, 2025
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
the
backport:release/v1.5.x
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the RESTMapper shipped in controller-runtime v0.20 for health check operations.
The Kubernetes Aggregated Discovery was enabled in controller-runtime#2901 and looks like this feature is buggy resulting in old API versions being returned as the preferred version randomly. While running the health checks, the controller would query old versions resulting in spurious logs about deprecated versions and in some cases, the health check would even fail.
This was observed on lots of cluster by Flux users, including on Kubernetes 1.32, 1.31 and OpenShift 4.16.
Depends on: fluxcd/pkg#873
Supersedes: #1374
Fixes: #1373
Test images:
ghcr.io/fluxcd/kustomize-controller:rc-8b6f4bc6docker.io/fluxcd/kustomize-controller:rc-8b6f4bc6