Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC-0009] Add CEL custom healthchecks #1344

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[RFC-0009] Add CEL custom healthchecks #1344

merged 1 commit into from
Jan 31, 2025

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp force-pushed the custom-healthchecks branch 2 times, most recently from 40b85a8 to 2aa2919 Compare January 24, 2025 19:55
@matheuscscp matheuscscp marked this pull request as ready for review January 27, 2025 08:57
@matheuscscp matheuscscp force-pushed the custom-healthchecks branch 2 times, most recently from d0ff0bf to 063b004 Compare January 27, 2025 15:54
matheuscscp
matheuscscp commented Jan 27, 2025
View reviewed changes
@matheuscscp matheuscscp force-pushed the custom-healthchecks branch 9 times, most recently from b227f6b to e6ca234 Compare January 31, 2025 13:25
stefanprodan
stefanprodan reviewed Jan 31, 2025
View reviewed changes
stefanprodan
stefanprodan reviewed Jan 31, 2025
View reviewed changes
@matheuscscp
[RFC-0009] Add CEL custom healthchecks
6455cfe 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@stefanprodan stefanprodan added the area/kstatus Health checking related issues and pull requests label Jan 31, 2025
stefanprodan
stefanprodan approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@stefanprodan stefanprodan added the enhancement New feature or request label Jan 31, 2025
@matheuscscp matheuscscp merged commit 5e620a5 into main Jan 31, 2025
8 checks passed
@matheuscscp matheuscscp deleted the custom-healthchecks branch January 31, 2025 15:40
@stefanprodan stefanprodan mentioned this pull request Feb 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/kstatus Health checking related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan