Skip to content

Commit

Permalink
feat: if a resource has a nil status, print that info
Browse files Browse the repository at this point in the history
This is better than just skipping that resource.
  • Loading branch information
Max Jonas Werner committed Jul 26, 2021
1 parent 91c27a1 commit 7eb782f
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions controllers/kustomization_healthcheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,15 @@ func (hc *KustomizeHealthCheck) Assess(pollInterval time.Duration) error {

if ctx.Err() == context.DeadlineExceeded {
errors := []string{}
for _, rs := range coll.ResourceStatuses {
if lastStatus[rs.Identifier].Status != status.CurrentStatus {
id := hc.objMetadataToString(rs.Identifier)
for id, rs := range coll.ResourceStatuses {
if rs == nil {
errors = append(errors, fmt.Sprintf("no status for %s available", id))
continue
}
if lastStatus[id].Status != status.CurrentStatus {
idString := hc.objMetadataToString(rs.Identifier)
var bld strings.Builder
bld.WriteString(fmt.Sprintf("%s (status '%s')", id, lastStatus[rs.Identifier].Status))
bld.WriteString(fmt.Sprintf("%s (status '%s')", idString, lastStatus[id].Status))
if rs.Error != nil {
bld.WriteString(fmt.Sprintf(": %s", rs.Error))
}
Expand Down

0 comments on commit 7eb782f

Please sign in to comment.