Add support for Helm --wait-for-jobs flag
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jun 1, 2021
|
Sure, I will make the change. I agree that gives a better experience by default. |
|
When you are done with the changes, please smash your commits into one as the change is quite small. Thank you ☕ |
|
Hi @hiddeco, I have inverted the flag and squashed my commits. Please review, thanks! |
hiddeco
reviewed
Jun 1, 2021
Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Added support for helm waitForJobs Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Minor fixes Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Changed WaitForJobs to DisableWaitForJobs Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Minor fixes Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Changed WaitForJobs to DisableWaitForJobs Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com> Removed unnecessary update to v2alpha1 Signed-off-by: Santosh Kewat <santoshkewat.bitmesra@gmail.com>
hiddeco
added
area/helm
hiddeco
changed the title
--wait-for-jobs flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for setting wait-for-jobs in HelmRelease.
helm/helm#5948