Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated io/ioutil #1668

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

dmitrika
Copy link
Contributor

@dmitrika dmitrika commented Jul 30, 2021

Ref: #1658

Signed-off-by: Dmitry Rybin <ayrowa@yandex.ru>
@dmitrika dmitrika force-pushed the chore/remove-deprecated-ioutil branch from 9c56d20 to 7f425ef Compare July 30, 2021 18:51
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello fellow city inhabitant! Thanks for your contribution 🍻 😄

Our (sub-)project requires a DCO sign-off, and without it we are unable to merge. Can you please follow the instructions here to add the sign-off to your commit? https://github.com/fluxcd/flux2/pull/1668/checks?check_run_id=3204812574

@dmitrika
Copy link
Contributor Author

@hiddeco hoi 👋 😄
Sure thing, updated.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you caught them all :-). Dankjewel!

If you are up for it, I know there are a lot of these left in fluxcd/pkg, and there may be some others in fluxcd/*-controller.

@hiddeco hiddeco merged commit eba6706 into fluxcd:main Jul 30, 2021
@dmitrika dmitrika deleted the chore/remove-deprecated-ioutil branch July 31, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants