[camera] Removed the microphone permission request from availableCameras on Web #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please take a look at the failing tests; analysis, unit tests, and several of our other automated checks are currently failing for this PR. |
|
Waiting for this fix. |
ditman
reviewed
Jul 11, 2023
ditman
reviewed
Jul 14, 2023
|
I'll tweak this branch to fix the CI. It needs to be rebased with the latest |
Co-authored-by: David Iglesias <ditman@gmail.com>
ditman
force-pushed
the
available_cameras_microphone_permission
branch
from
05b8c71 to
6176027
Compare
ditman
approved these changes
Jul 17, 2023
stuartmorgan
requested changes
Jul 18, 2023
| @@ -98,11 +98,7 @@ class CameraPlugin extends CameraPlatform { | |||
|
|
|||
| // Request video and audio permissions. | |||
There was a problem hiding this comment.
This comment is now incorrect.
| audio: AudioConstraints(enabled: true), | ||
| ), | ||
| ); | ||
| await _cameraService.getMediaStreamForOptions(const CameraOptions()); | ||
|
|
||
| // Release the camera stream used to request video and audio permissions. |
|
Addressed the comments regarding |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2023
…ableCameras on Web (flutter/packages#4263)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2023
…ableCameras on Web (flutter/packages#4263)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2023
flutter/packages@60e9a54...3dc00c1 2023-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd to 1d59196 (18 revisions) (flutter/packages#4621) 2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618) 2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614) 2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538) 2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
flutter/packages@60e9a54...3dc00c1 2023-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd to 1d59196 (18 revisions) (flutter/packages#4621) 2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618) 2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614) 2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538) 2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the microphone permission request from availableCameras on Web.
Adding an additional parameter would break either web or android/ios, so in my opinion it is better to change the web behavior.
Fixes flutter/flutter#112277
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.