Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router_builder] Include required and positional query parameters in the location #4163

Merged
merged 5 commits into from
Jun 9, 2023
Merged

[go_router_builder] Include required and positional query parameters in the location #4163

merged 5 commits into from
Jun 9, 2023

Conversation

ValentinVignal
Copy link
Contributor

Fixes flutter/flutter#128483

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal ValentinVignal requested a review from chunhtai as a code owner June 8, 2023 06:11
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ValentinVignal
Copy link
Contributor Author

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

I'm not sure why this is showing, I did update the tests

@Hixie
Copy link
Contributor

Hixie commented Jun 8, 2023

test-exempt: touches tests (the bot probably doesn't know about the specific file)

chunhtai
chunhtai approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj June 8, 2023 16:49
hannah-hyj
hannah-hyj approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ValentinVignal and others added 2 commits June 9, 2023 10:30
@ValentinVignal @chunhtai
Update packages/go_router_builder/CHANGELOG.md
099710b 
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
@ValentinVignal
Merge branch 'main' into go-router-builder/Add-required-query-paramet…
7c53956 
…ers-in-location
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit auto-submit bot merged commit cdb9bc6 into flutter:main Jun 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2023
@engine-flutter-autoroll
cdb9bc6 [go_router_builder] Include required and positional query par…
671862b 
…ameters in the location (flutter/packages#4163)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 12, 2023
@engine-flutter-autoroll
Roll Packages from afe2f05 to c9865e8 (6 revisions) (#128701)
353b8bc 
flutter/packages@afe2f05...c9865e8

2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter from da127f1 to 3df163f (25 revisions) (flutter/packages#4183)
2023-06-10 stuartmorgan@google.com [image_picker] Add desktop support (flutter/packages#3882)
2023-06-09 tarrinneal@gmail.com [image_picker] getMedia platform changes (flutter/packages#4174)
2023-06-09 stuartmorgan@google.com [image_picker] Add desktop support - implementations (flutter/packages#4172)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter from 6e254a3 to da127f1 (28 revisions) (flutter/packages#4170)
2023-06-09 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Include required and positional query parameters in the location (flutter/packages#4163)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[go_router_builder] Required query parameters are not included in the location
4 participants
@ValentinVignal @Hixie @chunhtai @hannah-hyj