Polish HostMessages #4515
Merged
Polish HostMessages #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| void _onReceivedLocation(String json) { | ||
| Map<String, num> reply = JSON.decode(json); | ||
| Map<String, num> reply = await HostMessages.sendJSON('getLocation', message); |
There was a problem hiding this comment.
won't the returned Map be a Map<String, dynamic> ?
|
LGTM. |
Cleans up a few style nits in hello_services and adds support for automatic JSON encoding and decoding to the HostMessages interface.
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
…r#4515) * Roll Dart to version 8d7219a5b6a7c2505ff57f23e7cf80da4c724512 * Update third_party license file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few style nits in hello_services and adds support for automatic
JSON encoding and decoding to the HostMessages interface.