Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] Workaround iOS text input crash for emoji+Korean text #36807

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 17, 2022

Hot fixing: flutter/flutter#111494
PR: #36295 and #34508

CP issue: flutter/flutter#112963

#36621 plus cherry pick #34508

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/36807

@jmagman
Copy link
Member Author

jmagman commented Oct 17, 2022

The tests pass on this PR https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/19879.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Oct 17, 2022

@godofredoc this is good to merge now, release is a go!

@godofredoc
Copy link
Contributor

@godofredoc this is good to merge now, release is a go!

Awesome, thanks!

@godofredoc godofredoc merged commit 3ad69d7 into flutter:flutter-3.2-candidate.5 Oct 17, 2022
@jmagman jmagman deleted the cp-emoji branch October 17, 2022 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants