Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit

Permalink
zach feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
gaaclarke committed Jun 8, 2023
1 parent 11dd70f commit c202c78
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 0 additions & 1 deletion shell/config.gni
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ declare_args() {
shell_enable_vulkan = false

shell_enable_software = true
enable_vulkan_validation_layers = false
}

declare_args() {
Expand Down
3 changes: 3 additions & 0 deletions shell/platform/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import("//build/config/android/config.gni")
import("//build/toolchain/clang.gni")
import("//flutter/build/zip_bundle.gni")
import("//flutter/common/config.gni")
import("//flutter/impeller/tools/impeller.gni")
import("//flutter/shell/config.gni")
import("//flutter/shell/gpu/gpu.gni")
import("//flutter/shell/version/version.gni")
import("//flutter/vulkan/config.gni")

shell_gpu_configuration("android_gpu_configuration") {
enable_software = true
Expand Down Expand Up @@ -479,6 +481,7 @@ action("android_jar") {
]

if (enable_vulkan_validation_layers) {
assert(impeller_enable_vulkan)
deps += [ "//third_party/vulkan_validation_layers" ]
args += [
"--native_lib",
Expand Down
2 changes: 1 addition & 1 deletion tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ def to_gn_args(args):

if args.enable_vulkan_validation_layers:
if args.target_os == 'android':
gn_args['android_api_level'] = int(26)
gn_args['android_api_level'] = 26
gn_args['enable_vulkan_validation_layers'] = True

# Enable pointer compression on 64-bit mobile targets. iOS is excluded due to
Expand Down
2 changes: 2 additions & 0 deletions vulkan/config.gni
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
# found in the LICENSE file.

declare_args() {
# Whether to include vulkan validation layers.
enable_vulkan_validation_layers = false
}

0 comments on commit c202c78

Please sign in to comment.