Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] Breaking changes in theming #596

Closed
batzen opened this issue Jul 27, 2018 · 2 comments
Closed

[Announcement] Breaking changes in theming #596

batzen opened this issue Jul 27, 2018 · 2 comments

Comments

@batzen
Copy link
Member

batzen commented Jul 27, 2018

This is an announcement about breaking changes to the current theming.

Currently you have to choose between BaseDark and BaseLight in combination with an accent like Blue.
This makes creating custom themes much more difficult than it should be because the so called AppTheme and Accent depend on each other.
To make it easier the new theming will work with a Theme only.
Such theme then contains all colors and brushes needed.

This means that in the future instead of referencing two files you just have to reference something like Dark.Blue or Light.Blue.
The ThemeManager will also be changed to reflect these changes.
To maintain interop with MahApps.Metro these changes will also be made there.

These changes will be part of version 7.0.

@batzen batzen added this to the 7.0.0 milestone Jul 27, 2018
@batzen batzen self-assigned this Jul 27, 2018
@batzen
Copy link
Member Author

batzen commented Jul 27, 2018

@GeertvanHorrik FYI

@batzen
Copy link
Member Author

batzen commented Jul 27, 2018

@punker76 I guess you might want to announce this in MahApps.Metro too ;-)

batzen added a commit that referenced this issue Aug 2, 2018
@batzen batzen pinned this issue Dec 25, 2018
@batzen batzen closed this as completed Nov 24, 2019
@batzen batzen unpinned this issue Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant