Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some unit test coverage for credentials;metrics;env/fs packages #3943

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Feb 20, 2025

First pass at increasing UT coverage

Re: #3942

…kages

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@656ecfa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nternal/storage/environments/fs/testing/testing.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #3943   +/-   ##
=====================================
  Coverage      ?   53.51%           
=====================================
  Files         ?      117           
  Lines         ?    10754           
  Branches      ?        0           
=====================================
  Hits          ?     5755           
  Misses        ?     4614           
  Partials      ?      385           
Flag Coverage Δ
unittests 53.51% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps marked this pull request as ready for review February 21, 2025 00:00
@markphelps markphelps requested a review from a team as a code owner February 21, 2025 00:00
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 21, 2025
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps merged commit 51c9c94 into v2 Feb 21, 2025
14 of 15 checks passed
@markphelps markphelps deleted the v2-unit-test-cov-one branch February 21, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant