CE-534: Add support to handle producing union type of multiple records #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Feb 25, 2025
| _is_integer_string?(val) || | ||
| int_classes.any? { |klass| val.is_a?(klass) } | ||
| when :float, :double | ||
| val.is_a?(Numeric) || _is_float_string?(val) |
There was a problem hiding this comment.
Shouldn't this be Float instead of Numeric?
There was a problem hiding this comment.
I just tested with Float and it still works so I changed it to Float. Added a test for it as well. I copied it from this method for reference https://github.com/flipp-oss/deimos/blob/master/lib/deimos/schema_backends/avro_schema_coercer.rb#L56C7-L58C19
dorner
previously approved these changes
Feb 26, 2025
When determining data types from a union of different data types, compare the fields for schema type: record with the values to determine the right schema type.
Check for Float instead of Numeric type when looking for schema within a Union Schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to detect the right schema type from a UnionSchema
Fixes https://flippit.atlassian.net/browse/CIE-534
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Tested the change on Item-Platform using this branch (to reproduce the issue) https://github.com/wishabi/item-platform/commit/560cdd748b9335dc9dee9aeeaa65e94f23cb1988
Verified that the existing Kafka specs pass on Item-Platform
Checklist: