Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supporting new cp hook to display provider buttons #227

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

nateiler
Copy link
Contributor

@dsmrt Let's review this; this should use the upcoming hook for our provider buttons.

I remove some of the obvious legacy login template code, but there may be stuff that I missed.

@nateiler nateiler requested a review from dsmrt January 24, 2025 16:58
@dsmrt
Copy link
Contributor

dsmrt commented Jan 28, 2025

Screenshot 2025-01-27 at 5 03 31 PM

Button are looking good

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.72%. Comparing base (c22f57f) to head (fffe82f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Saml.php 60.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
- Coverage     82.33%   81.72%   -0.62%     
+ Complexity      171      170       -1     
============================================
  Files            16       16              
  Lines           651      651              
============================================
- Hits            536      532       -4     
- Misses          115      119       +4     
Files with missing lines Coverage Δ
src/Saml.php 91.17% <60.00%> (-5.89%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22f57f...fffe82f. Read the comment docs.

@dsmrt
Copy link
Contributor

dsmrt commented Jan 28, 2025

Bonus!! These get added to the elevated session login too!
Screenshot 2025-01-27 at 6 18 44 PM

@dsmrt dsmrt merged commit bcf567e into master Jan 29, 2025
2 of 4 checks passed
@dsmrt dsmrt deleted the issue/226 branch January 29, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants