FOGL-8115: Add Control Entry-points API Flow #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonikaSharma06
requested review from
praveen-garg,
mshariq-nerd and
hemantgarg923
| @@ -419,7 +416,7 @@ | |||
| <div class="field"> | |||
| <div class="columns"> | |||
| <div class="column is-2"> | |||
| <div *ngIf="editMode && allowExecute" class="field has-addons is-fullwidth"> | |||
| <div *ngIf="editMode && af.permitted" class="field has-addons is-fullwidth"> | |||
There was a problem hiding this comment.
All conditionals stuff with edit mode for permitted needs proper testing; for each role based user; and not auth mode.
MonikaSharma06
changed the title
...mponents/core/control-dispatcher/api-flow/add-edit-api-flow/add-edit-api-flow.component.html
Outdated
Show resolved
Hide resolved
...components/core/control-dispatcher/api-flow/add-edit-api-flow/add-edit-api-flow.component.ts
Outdated
Show resolved
Hide resolved
...components/core/control-dispatcher/api-flow/add-edit-api-flow/add-edit-api-flow.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/core/control-dispatcher/api-flow/api-flow.component.html
Outdated
Show resolved
Hide resolved
...mponents/core/control-dispatcher/api-flow/add-edit-api-flow/add-edit-api-flow.component.html
Outdated
Show resolved
Hide resolved
praveen-garg
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form validation related changes and other css fixes