Adapt e-antic to FLINT 3 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somehow autotools does not like conditional symbols like we had before and tells us that the symbol is undefined.
contrary to https://lists.gnu.org/archive/html/bug-autoconf/2006-05/msg00033.html this check did not get pulled out of the if statement correctly.
This reverts commit e994197.
This reverts commit c3d095f.
This reverts commit 984ca23.
I misunderstood the previous error messages. They do not come from autoconf but from automake. So, making sure that the HAVE_LIBANTIC is defined in all conditional blocks should fix it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 105 105
Lines 2125 2125
=======================================
Hits 1960 1960
Misses 165 165 ☔ View full report in Codecov by Sentry. |
note that no released SageMath works with FLINT 3 yet
so we can use a newer libcxx
Closed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/news/.TODO