-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move locale files from language pack to extensions #175
Move locale files from language pack to extensions #175
Conversation
@rob006 we've discussed this internally and are ready to proceed, sorry for the delay in acting on this. Could you update the core and tags PRs to reflect changes made since this was opened? |
I'll try to do it this evening or tomorrow. There is also a new extension to move (nicknames). |
Thank you so much for bearing with us on this! |
@askvortsov1 Done. |
@askvortsov1 I think you missed flarum/nicknames#3 |
I did, thanks for finding that :D |
…cale files from language pack to extensions. refs flarum/lang-english#175
… files were moved from language pack to extensions and for now there is no stable release with locale file in extension repository. refs flarum/lang-english#175
How this affects other language packs? By the way, with this change, translators cannot follow changes/commits easily. 😟 |
Important question, but could you put it in flarum/framework#2090, which is the global issue for discussion? |
@qiaeru AFAIK it does not affect other language packs at all. While it indeed may make it harder to sync changes, core extensions are only part of the ecosystem and most of installations will use also other community extensions, so to make useful language pack you need to cover also other translations that were never available in this repository. I highly recommend to take a look at https://discuss.flarum.org/d/20807-simplify-translation-process-with-weblate. You can also track all changes in https://github.com/rob006-software/flarum-translations/commits/master/sources - there should all changes in translations of any popular extension. |
flarum/lang-english#175 Signed-off-by: corvofeng <corvofeng@gmail.com>
Fixes flarum/framework#2090
This changes English language pack into simple stub that does not have any translations (all related translations are in respective packages), but only enables English language in forum. This should:
Dependencies: