Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overflowing forum stats #3940

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: overflowing forum stats #3940

merged 1 commit into from
Dec 1, 2023

Conversation

datlechin
Copy link
Contributor

before
Screenshot 2023-11-26 at 00 06 55

after
Screenshot 2023-11-26 at 00 07 37

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner November 25, 2023 17:08
@SychO9 SychO9 added the type/bug label Dec 1, 2023
@SychO9 SychO9 changed the title Fix forum stats entities responsive issue fix: overflowing forum stats entities responsive issue Dec 1, 2023
@SychO9 SychO9 changed the title fix: overflowing forum stats entities responsive issue fix: overflowing forum stats Dec 1, 2023
@SychO9 SychO9 added this to the 2.0 milestone Dec 1, 2023
@SychO9 SychO9 merged commit b4a82e8 into flarum:2.x Dec 1, 2023
@datlechin datlechin deleted the dat/fix-responsive-issue branch December 2, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@datlechin @davwheat @SychO9