Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use hex_color rule for color validation #3936

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: use hex_color rule for color validation #3936

merged 1 commit into from
Jan 19, 2024

Conversation

datlechin
Copy link
Contributor

Add the hex_color rule to Laravel's validation system for improved color validation.

See here: laravel/framework#49056

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner November 25, 2023 16:29
@datlechin datlechin changed the title Use hex_color rule for color validation [2.x] Use hex_color rule for color validation Nov 25, 2023
@SychO9 SychO9 changed the title [2.x] Use hex_color rule for color validation chore: use hex_color rule for color validation Jan 19, 2024
@SychO9 SychO9 added this to the 2.0 milestone Jan 19, 2024
@SychO9 SychO9 merged commit 734f4a1 into flarum:2.x Jan 19, 2024
@datlechin datlechin deleted the dat/hex-color branch January 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants