Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tags): tag selection modal shown when no tags can be selected #3448

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(tags): tag selection modal shown when no tags can be selected #3448

merged 1 commit into from
Jun 20, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 3, 2022 •
edited
Loading

Fixes #3444

Changes proposed in this pull request:
Checks that maxPrimaryTags and maxSecondaryTags are not nil before showing tag selection modal.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 self-assigned this Jun 18, 2022
@SychO9 SychO9 force-pushed the sm/3444-tag-selection-modal branch from 4cbd770 to 1c9ccb0 Compare June 20, 2022 14:54
@SychO9 SychO9 force-pushed the sm/3444-tag-selection-modal branch from 1c9ccb0 to f608cb8 Compare June 20, 2022 14:55
@SychO9 SychO9 merged commit 613523c into main Jun 20, 2022
@SychO9 SychO9 deleted the sm/3444-tag-selection-modal branch June 20, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tag prompt shows up even for a 0 to 0 tag requirements
2 participants
@SychO9 @davwheat