feat: allow multiple children to be passed to ConfirmDocumentUnload component #3372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Lets you pass multiple children to the ConfirmDocumentUnload component through the use of a Mithril fragment.
Reviewers should focus on:
As far as I can see, the only reason this was not done before was because of the impression that this could only be done through a wrapping DOM component rather than a fragment.
Necessity
Confirmed
composer test
).