Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): fix a11y warning in alert, and other a11y fixes #3237

Merged
merged 3 commits into from
Dec 28, 2021
Merged

fix(a11y): fix a11y warning in alert, and other a11y fixes #3237

merged 3 commits into from
Dec 28, 2021

Conversation

davwheat
Copy link
Member

Progresses #3360, progresses #3365

Changes proposed in this pull request:

  • add missing a11y label for alert dismiss button
  • use aria live regions to focus screenreader attention on alerts as they appear

Reviewers should focus on:

N/A

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Dec 28, 2021
@davwheat davwheat added this to the 1.2 milestone Dec 28, 2021
@davwheat davwheat self-assigned this Dec 28, 2021
@davwheat davwheat merged commit 993500a into master Dec 28, 2021
@davwheat davwheat deleted the dw/alert-a11y branch December 28, 2021 20:08
@davwheat davwheat mentioned this pull request Mar 28, 2022
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @tankerkiller125 @askvortsov1