Various iOS scroll improvements #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alleviates the scrubber bouncing around when scrolling up on iOS
Throttle loadMore and loadPrevious functions to alleviate skipping over pages and pages of posts during one scroll. This sometimes happens on iOS
|
Code looks fine. How much does the import increase bundle size by? |
|
355.3 kB without, 357.1kB with |
SychO9
approved these changes
Jan 20, 2021
@datitisev is that alright with you? I got my hands on an ipad to test the way it is now, and it's really inconvenient for iOS users, so it'd be good to get this fixed. |
|
@askvortsov1 Yeah fine with me. |
matteocontrini
pushed a commit
to fibraclick/flarum-framework
that referenced
this pull request
Feb 18, 2021
* Don't update scrubber while post pages loading This alleviates the scrubber bouncing around when scrolling up on iOS * Throttle loadMore loadPrevious Throttle loadMore and loadPrevious functions to alleviate skipping over pages and pages of posts during one scroll. This sometimes happens on iOS
KyrneDev
pushed a commit
that referenced
this pull request
Feb 20, 2021
* Don't update scrubber while post pages loading This alleviates the scrubber bouncing around when scrolling up on iOS * Throttle loadMore loadPrevious Throttle loadMore and loadPrevious functions to alleviate skipping over pages and pages of posts during one scroll. This sometimes happens on iOS
askvortsov1
added a commit
that referenced
this pull request
Feb 21, 2021
* Don't update scrubber while post pages loading This alleviates the scrubber bouncing around when scrolling up on iOS * Throttle loadMore loadPrevious Throttle loadMore and loadPrevious functions to alleviate skipping over pages and pages of posts during one scroll. This sometimes happens on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://discuss.flarum.org/d/25643-up-scroll-skips-posts/10
Changes made are:
I was unable to fix an issue where it skips posts when a finger is held on the screen while at the top of the page, but that's present in previous releases of Flarum too (and I've managed to replicate that in Discourse as well): seems like an iOS quirk. However, fast/momentum based scrolls (vast majority), or scrolls when the user lets go when they get to the top, should be almost completely fixed.