Allow formatting post content without the HTTP request #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the code shows, you can also use the Formatter directly to render. That's why I'm in dubio.. I see this is based on an existing issue. Let's wait for either @clarkwinkelmann or @franzliedke to pitch in. |
|
Indeed, it's not an absolutely needed change because it can be done without using this method. But I think the change is so simple, it would be counter-productive to not allow re-using that method in every contexts. It makes extensions easier to develop by not having to resolve the formatter yourself. It's easier to explain how to use it, and it's also maybe easier to read code that uses the method. |
clarkwinkelmann
approved these changes
Sep 2, 2019
luceos
pushed a commit
that referenced
this pull request
Feb 4, 2020
wzdiyb
pushed a commit
to wzdiyb/core
that referenced
this pull request
Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1840
Changes proposed in this pull request:
This change allows the
formatContent()method on theCommentPostto be called without an HTTP request.Confirmed
php vendor/bin/phpunit).