Allow extensions to specify a load priority #1838
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow a simple fix to #1832 as well as other load priority problems. I have confirmed that after using these proposed changes + adding a priority to the lock extension the issue went away.
Changes proposed in this pull request:
Allow extensions to specify an optional load "priority" in their
composer.json
under Flarum extension that dictates the order they are loaded in (higher means first)Reviewers should focus on:
Is this the best way to do this?
Confirmed
php vendor/bin/phpunit
).Required changes: