ApproveContent then refresh user table DiscussionCount and CommentCount

[imzhi]

After approve the operation, update the discussion_count and comment_count fields of the users table

[askvortsov1]

Looks good to me, thank you!

[clarkwinkelmann]

Would it make sense to move $user->refreshDiscussionCount() inside of the condition block?

The discussion count shouldn't change unless we're also approving the discussion.

This probably doesn't have a big impact but would save a database query where possible.

[askvortsov1]

Agreed.

[franzliedke]

@clarkwinkelmann Do you mean the if ($post->number == 1) block? That would be before the discussion save, so the result would be different, right?

[clarkwinkelmann]

Sorry I didn't reply to this right away.

Yes now that I re-read my suggestion it requires a bit more code. Essentially this:

        if ($post->number == 1) {
            $discussion->is_approved = true;
        }

        $discussion->save();

        $user->refreshDiscussionCount();
        $user->refreshCommentCount();
        $user->save();

could be replaced with

        if ($post->number == 1) {
            $discussion->is_approved = true;
        }

        $discussion->save();


        if ($post->number == 1) {
            $user->refreshDiscussionCount();
        }

        $user->refreshCommentCount();
        $user->save();

or

        if ($post->number == 1) {
            $discussion->is_approved = true;

            $discussion->afterSave(function () use ($user) {
                $user->refreshDiscussionCount();
            });
        }

        $discussion->save();

        $user->refreshCommentCount();
        $user->save();

To save a database request.

Not sure if it's worth the optimization though.

[askvortsov1]

I like the second one

[askvortsov1]

@imzhi would you be interested in updating this PR as discussed above?

[imzhi]

@askvortsov1 A new commit was finished based on the discussion.