Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRC130 Various small changes #34

Merged
merged 20 commits into from
Nov 27, 2024
Merged

WRC130 Various small changes #34

merged 20 commits into from
Nov 27, 2024

Conversation

mixmixmix
Copy link
Member

  • Expanded gitignore for popular temporary files
  • By accident blackened some files
  • compressed background image
  • corrected display of background image
  • In the schema I've changed program areas and added empty fields for approval
  • Change incorrect references to "Category" as "Group"
  • Change name "Private" to "Internal"
  • Added configuration of the login button from ansible variable
  • Added about page.

Testing

I did reasonable amount of user testing :)

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other projects (AFRO) when we wanted to rename groups we didn't just create templates overwriting it - we used the translation engine to make an "English (Fjelltoppian)" - this is more robust and also compatible with plugins. @A-Souhei can advise on how much work this was?

@mixmixmix mixmixmix merged commit 048d7f7 into master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants