Use object-assign module as replacement for es6-shim #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects an issue running firmata inside of a Chrome App, where es6-shim conflicted with Chrome's CSP. Specifically, this line was the culprit: https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L72 If in the future more ES6 methods are used, another solution might be found (or a patch submitted to es6-shims).
Did you report this to es6-shim? |
rwaldron
added a commit
that referenced
this pull request
Nov 7, 2014
Use object-assign module as replacement for es6-shim
|
Drafting up the issue right now actually - it seems they added that line more for convenience than anything else. edit: - paulmillr/es6-shim#301 |
|
Not convenience - it's the only guaranteed way to get the global object. Please do suggest any alternatives on the es6-shim issue :-) |
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "browser-serialport": "*", | |||
| "es6-shim": "^0.20.2", | |||
| "object-assign": "^1.0.0", | |||
There was a problem hiding this comment.
I recommend not using "^" as it's developer-hostile to anyone using node older than 0.10.24. I stick with ~ on all my modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue running firmata inside of a Chrome App, where es6-shim conflicted with Chrome's CSP.
Specifically, this line was the culprit.
This could be worked around with sandboxing, but that disables all
chrome.*APIs, makingbrowser-serialportnon-functional.To fix the issue, and since only one ES6 feature was used (
Object#assign), I've added Sindre Sorhus'sobject-assignponyfill.If in the future more ES6 methods are used, another solution might be found (or a patch submitted to es6-shims).
Please let me know if there's anything wrong with this patch, and I'll try to get any issues fixed.