-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_storage] Support for download progress #2884
[firebase_storage] Support for download progress #2884
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
For those who might be wondering how to use this right away, use this on your pub spec.
Note: On the Windows environment, you might get weird long pathname issues, follow here. A star on my fork would be appreciated if it helped you, Thanks. :-) |
Example Usage
|
@awazgyawali Lol I figured it out minutes after I commented so I deleted it. Thanks anyways |
Any timeline on when will this because a part of the official release? |
There is an ongoing refactor of the whole package paradigm from invertase at #2582 Once it is stable, I will maintain the PR and might get reviewed too. Please expect a timeline of around about a month. |
… storage_download_progress
Thanks for the update @awazgyawali. Just to confirm, you're keeping this PR on hold until the |
Yes, we are only interested on |
I have tried using the above suggestion, but got the following errors (on firebase_auth):
FAILURE: Build failed with an exception. Is there any way to use a version of firebase_auth that is aligned with the changes in the above suggested repository? I have tried using the following:
but got the following error:
Thanks! |
Use the following
|
Tried, got:
|
I edited my comment :-) |
Still getting the following errors:
Which version of firebase_auth should I use? (currently using latest release) |
I could not establish a working set of firebase_auth, firebase_storage, firebase_messaging and firebase_core with the support for download progress. Thanks! |
pubspec.txt |
Thanks, following set seems to be working:
|
Hi, I have noticed the following incorrect behavior when using pause/resume functionality on download operation. There is a glitch in the progress reporting due to:
See following log to clarify the issue, let me know if you need more information:
|
When trying to pause the transfer on iOS, the operation fails with the following message:
Is there some different setup required for iOS? |
@awazgyawali Appreciate your help with the above two issue. |
Dear @awazgyawali , Is there any chance someone can attend it? Thanks,
|
@yanivshaked This PR has not been merged, @Salakar and the team re worked on the plugin and introduced the download progress feature. May be he can help you with this. |
Dear @Salakar, Thanks, |
Description
Adds support for Download Progress;
Related Issues
#420
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?