Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS for Auth #8694

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Update CODEOWNERS for Auth #8694

merged 1 commit into from
Jan 8, 2025

Conversation

NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Jan 8, 2025

Make BLR team members and myself Auth owners.

@NhienLam NhienLam requested a review from a team as a code owner January 8, 2025 17:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: da796b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (25a6204) and merge commit (6c97111).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qS1pXt63Gb.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (25a6204) and merge commit (6c97111).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LOaUXP9jXE.html

@NhienLam NhienLam merged commit 645487b into main Jan 8, 2025
39 checks passed
@NhienLam NhienLam deleted the nhienlam-1 branch January 8, 2025 18:11
mansisampat
mansisampat reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mansisampat mansisampat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@firebase firebase locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mansisampat mansisampat mansisampat left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

@pashanka pashanka Awaiting requested review from pashanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NhienLam @google-oss-bot @hsubox76 @mansisampat