Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui_localizations): Add Romanian localization #174

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

viceamarian
Copy link
Contributor

@viceamarian viceamarian commented Nov 3, 2023

Description

Add localization for romanian language.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@viceamarian
Copy link
Contributor Author

@lesnitsky I have made the changes needed in "all_languages.dart" and got an approval of this PR from a Romanian speaking developer.

@viceamarian viceamarian changed the title feat(ui_localizations): Add romanian localization feat(ui_localizations): Add Romanian localization Nov 7, 2023
@lesnitsky lesnitsky merged commit dc9c9cb into firebase:main Nov 9, 2023
@viceamarian viceamarian deleted the feature/ui_localizations_ro branch November 9, 2023 19:56
@viceamarian
Copy link
Contributor Author

Thank you, @lesnitsky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants