Remove unused proguard files and fix ./gradlew build not working because of failing tests
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of failing tests Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
SUPERCILEX
commented
Feb 5, 2017
| # See: | ||
| # https://firebase.google.com/docs/auth/android/start/#proguard | ||
| -keepattributes Signature | ||
| -keepattributes *Annotation* |
There was a problem hiding this comment.
I don't think any of this is necessary because we add consumerProguardFiles.
| // TODO Remove once either Facebook or Robolectric fix the crash: https://github.com/robolectric/robolectric/issues/2579#issuecomment-276526911 | ||
| gradle.taskGraph.whenReady { graph -> | ||
| graph.allTasks.findAll { it.name ==~ /testReleaseUnitTest/ }*.enabled = false | ||
| } |
There was a problem hiding this comment.
This is a more permanent solution with a TODO that disables release unit tests for all gradle tasks. Unfortunately, I couldn't find a way to disable a task from within another task eg disable testReleaseUnitTest just for the build task which would have been preferable.
There was a problem hiding this comment.
This LGTM, it's a better solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
./gradlew buildfails.