Save phone verification ID across process deaths #1393
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
| @@ -60,4 +63,14 @@ public void submitVerificationCode(String number, String code) { | |||
| PhoneAuthProvider.getCredential(mVerificationId, code), | |||
| false))); | |||
| } | |||
|
|
|||
| public void onSaveInstanceState(@NonNull Bundle outState) { | |||
| outState.putString(VERIFICATION_ID_KEY, mVerificationId); | |||
There was a problem hiding this comment.
I have no issue with this, but just wondering have you seen this pattern of handing the instance state in the ViewModel elsewhere or is this your own invention? Seems a to tie it a little too close to the Activity but I can't think of a reason why it's any worse than having the logic directly in the Activity.
There was a problem hiding this comment.
I looked around, but couldn't find sample code with onSaveInstanceState. 😕 So I guess it's time to patent my new invention, right? 😂
I wouldn't mind moving it to the activity, but it made more sense to me to let the ViewModel manage its saved state. (Otherwise, we'd end up with getters and setters for mVerificationId which shouldn't be used outside of the state restoration context.) Whad'ya think?
There was a problem hiding this comment.
I am cool with it, let's just pinky swear not to show Jake Wharton or Yigit the monster we've created!
Fixes #1392