APP-3283: Implemented datafeed id reuse #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
requested review from
a team,
symphony-hong,
thibauult and
symphony-youri
| self.datafeed_client = self.bot_client.get_datafeed_client() | ||
| self.datafeed_id_repository = OnDiskDatafeedIdRepository(self.config.get_datafeed_id_folder_path()) |
There was a problem hiding this comment.
as it is specific to v1 only is it a logic we could push down to the subclass?
There was a problem hiding this comment.
Indeed but it would require to duplicate this logic in AsyncDataFeedEventService and in DataFeedEventServiceV1.
thibauult
reviewed
Nov 19, 2020
|
Was able to test it on devx1 by sending a message OBO. |
thibauult
previously approved these changes
Nov 20, 2020
symphony-youri
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
APP-3283
Description
Implementing reuse and persistence of datafeed id when using DFv1
Checklist