PLAT-10893 Check for duplicate slash commands #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal of this implementation is to check when registering a new slash command that is not equal to any of the already existing ones. A slash command is considered equal when both name value and mention_bot boolean are the same.
symphony-mariacristina
requested review from
symphony-elias,
symphony-youness,
a team and
thibauult
| @@ -81,3 +80,12 @@ def matches(self, context: CommandContext) -> bool: | |||
|
|
|||
| async def on_activity(self, context: CommandContext): | |||
| await self._callback(context) | |||
|
|
|||
| def __eq__(self, o: object) -> bool: | |||
| if isinstance(o, SlashCommandActivity): | |||
There was a problem hiding this comment.
do we need to check if "o" is None ?
There was a problem hiding this comment.
No, if o is None, it is of type NoneType and isinstance(o, SlashCommandActivity) will return False.
Tested on the Python console:
.
symphony-soufiane
approved these changes
May 31, 2021
symphony-elias
suggested changes
Jun 1, 2021
tests/core/activity/registry_test.py
Outdated
| mention_bot = True | ||
| command_name = "/command" | ||
|
|
||
| activity_registry.slash(command_name, mention_bot)(listener) |
There was a problem hiding this comment.
Please consider having two different listener instances to check we do not blindly make a reference equality check
There was a problem hiding this comment.
you are right, I missed that. Done in cd17c57
symphony-elias
approved these changes
Jun 1, 2021
symphony-elias
added a commit
that referenced
this pull request
Jun 7, 2021
* PLAT-10782: Support of multiple bot instances (#194) * Updated poetry deps * PLAT-10782: Implemented proper handling of ackId in DatafeedLoopV2 to support multiple bot instances * Fixed pylint issues * PLAT-10893 Check for duplicate slash commands (#195) * PLAT-10893 Check for duplicate slash commands Goal of this implementation is to check when registering a new slash command that is not equal to any of the already existing ones. A slash command is considered equal when both name value and mention_bot boolean are the same. * Fixed documentation (#198) * PLAT-10868 Remove certificates and private keys credentials (#200) * PLAT-10868 Remove certificates and private keys credentials * PLAT-10895-Implement built-in help command (#197) * PLAT-10895-Implement built-in help command Goal of this PR is to provide the implementation of a build-in help command with lists all the activity registered in the ActivityRegistry. For each command found the following format will be used " - command_name - description (mention required/mention not required)" (example "/hello - command to say hello (mention required)") This help command can also be overriden by manually implementing a new SlashCommandActivity, the code will make sure that any duplicates will be removed. * PLAT-10944: passed bot service account info in RealTimeEventListener.is_accepting_event (#201) * Bumped version to 2.0b4 Co-authored-by: Mariacristina De Dominicis <65179248+symphony-mariacristina@users.noreply.github.com> Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-10893
Description
Goal of this implementation is to check when registering a new slash command that is not equal to any of the already existing ones. A slash command is considered equal when both name value and mention_bot boolean are the same.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist