Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10646: Unknown event breaks DF loop #152

Merged

Conversation

symphony-youri
Copy link
Contributor

Ticket

PLAT-10646

Description

An unknown event was causing the handle_events part of the DF loop to
exit (i.e return instead of continuing the loop).

Also print the event type in the log to have it with context.

Dependencies

N/A

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • [-] Docstrings added or updated
  • [-] Updated the documentation in docs folder

An unknown event was causing the handle_events part of the DF loop to
exit (i.e return instead of continuing the loop).

Also print the event type in the log to have it with context.
@symphony-youri symphony-youri requested review from symphony-youness and a team March 18, 2021 18:05
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@symphony-elias symphony-elias added this to the 2.0.0 milestone Mar 18, 2021
@symphony-youri symphony-youri merged commit 6d58eb2 into finos:master Mar 19, 2021
@symphony-elias symphony-elias removed this from the 2.0.0 milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants