PLAT-10343: Datafeed V2 service implementation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the BdkDatafeedConfig class, check if the `datafeed.version` configuration is specified. If not, the datafeed version equals `v1` In the ServiceFactory class, check if the datafeed version is configured as `v2`, return the DatafeedLoopV2 instance. Otherwise, the DatafeedLoopV1 will be used by default. Implementation the datafeed v2 loop service in DatafeedLoopV2 class
symphony-hong
requested review from
thibauult,
symphony-youri and
symphony-elias
symphony-hong
force-pushed
the
PLAT-10343
branch
from
acd6e38 to
2abb649
Compare
symphony-elias
approved these changes
Feb 16, 2021
thibauult
reviewed
Feb 16, 2021
There was a problem hiding this comment.
No need to modify https://github.com/SymphonyPlatformSolutions/symphony-api-client-python/blob/2.0/docs/configuration.md?
Just to let appears that DF version can be changed through config.yaml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for early review without unittest yet
Ticket
PLAT-10343
Description
Datafeed V2 service implementation.
In the BdkDatafeedConfig class, check if the
datafeed.versionconfiguration isspecified. If not, the datafeed version equals
v1In the ServiceFactory class, check if the datafeed version is configured as
v2, returnthe DatafeedLoopV2 instance. Otherwise, the DatafeedLoopV1 will be used by default.
Implementation the datafeed v2 loop service in DatafeedLoopV2 class
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist