PLAT-10460: Implemented OBO-enabled endpoints #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
requested review from
thibauult,
symphony-youri and
symphony-hong
symphony-elias
commented
Feb 15, 2021
| async def __aenter__(self): | ||
| return self | ||
|
|
||
| async def __aexit__(self, exc_type, exc_val, exc_tb): |
There was a problem hiding this comment.
how do we document that you should use async with here?
There was a problem hiding this comment.
I added code samples in docs/authentication.md.
| self._config = config | ||
| self._obo_session = obo_session | ||
|
|
||
| self._api_client_factory = ApiClientFactory(config) |
There was a problem hiding this comment.
should we recreate one or reuse the one from BDK? (I'm wondering why we did it like that for the Java BDK)
There was a problem hiding this comment.
In java, we recreate a new one:
- https://github.com/SymphonyPlatformSolutions/symphony-api-client-java/blob/master/symphony-bdk-core/src/main/java/com/symphony/bdk/core/SymphonyBdk.java#L258
- https://github.com/SymphonyPlatformSolutions/symphony-api-client-java/blob/364fc4309fb44bab2054d310d8deededc6935c88/symphony-bdk-core/src/main/java/com/symphony/bdk/core/OboServices.java#L31
There was a problem hiding this comment.
Yep that's what I was wondering, do we have a good reason to do it?
If we reuse the existing one from BDK it means we don't have to use async with
symphony-youri
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-10460
Description
Implemented OBO-enabled endpoints.
Checklist