PLAT-10370: Connection Service Implementation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnectionService class in connection_service.py to wrap all the connection endpoints presented in https://developers.symphony.com/restapi/reference ConnectionStatus enumeration in connection_status.py listing out all the available value can be set to Connection status. ServiceFactory class in service_factory.py to construct the Service and provide them to the SymphonyBdk entry point. SymphonyBdk#connections to use the connection service from the Bdk entry point. ConnectionService example added. Unittest added. Docstring added.
symphony-hong
requested review from
thibauult,
symphony-youri,
symphony-elias and
a team
thibauult
reviewed
Feb 9, 2021
symphony-hong
force-pushed
the
PLAT-10370
branch
from
4d098cf to
fcfc29d
Compare
symphony-hong
force-pushed
the
PLAT-10370
branch
from
0241088 to
6de7fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-10370
Description
Connection Service Implementation
ConnectionService class in connection_service.py to wrap all the connection endpoints presented in https://developers.symphony.com/restapi/reference
ConnectionStatus enumeration in connection_status.py listing out all the available value can be set to Connection status.
ServiceFactory class in service_factory.py to construct the Service and provide them to the SymphonyBdk entry point.
SymphonyBdk#connections to use the connection service from the Bdk entry point.
ConnectionService example added.
Unittest added.
Docstring added.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist