Option to apply all events before state entry functions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows processing of multiple events before calling a state entry func
hannahhoward
force-pushed
the
feat/apply-all-events-option
branch
from
4b76c41 to
f86db30
Compare
rvagg
approved these changes
May 12, 2022
There was a problem hiding this comment.
My only critique here is that the tests don't really seem to be testing anything specific about consumeAllEventsBeforeEntryFuncs except for the incompleteness in TestConsumeAllEvents. But the tests do make sure events are processed, just nothing particularly special about the way they are processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This PR adds a long requested feature to go-statemachine -- to process multiple events at once before we apply the next StateEntryFunc.
Implementation
Adds an optional parameter to process multiple state machine updates before applying a state entry func. This has been an ongoing issue where StateEntryFuncs get called after already being outdated by additional state machine events.
It's added as an optional parameter as this is a potentially far reaching change and it's worth rolling it out gradually.