Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to providers in fiberplane-rs #74

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Point to providers in fiberplane-rs #74

merged 5 commits into from
Aug 16, 2022

Conversation

emschwartz
Copy link
Contributor

No description provided.

@emschwartz emschwartz requested a review from a team as a code owner August 12, 2022 08:07
@emschwartz
Copy link
Contributor Author

@arendjr the test where it invokes the providers is failing with this error. Any idea what that's about?

Provider log: prometheus provider invoked with request: Status, config: Array([String(Utf8String { s: Ok("http://127.0.0.1:57175") })])
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Link(Import("__wbindgen_placeholder__", "__wbindgen_describe", UnknownImport(Function(FunctionType { params: [I32], results: [] }))))', /Users/emschwartz/.cargo/git/checkouts/fiberplane-rs-5049e26e67ac1a68/e2f20ae/provider-protocol/generated/fp-provider-runtime/src/spec/bindings.rs:186:68
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Provider log: prometheus provider invoked with request: Status, config: Array([String(Utf8String { s: Ok("http://127.0.0.1:57158") })])
thread 'tests::sends_data_sources_on_connect' panicked at 'assertion failed: `(left == right)`
  left: `Details(DataSourceDetails { ty: Elasticsearch, status: Error("Did not receive a status response from the provider") })`,
 right: `Details(DataSourceDetails { ty: Elasticsearch, status: Connected })`', proxy/src/tests.rs:199:17

@arendjr
Copy link
Contributor

arendjr commented Aug 12, 2022

Oh, @sagacity and I ran into this the other day. You need to make sure time is pinned to the previous version, because the latest one assumes that anyone targeting wasm is using wasm-bindgen, which triggers these unresolved symbols during linking. I think Roy made an issue for it.

@emschwartz
Copy link
Contributor Author

@arendjr I updated the time dep to the latest version which says it contains a fix for that issue but the test is still failing. https://github.com/time-rs/time/blob/main/CHANGELOG.md#0313-2022-08-09

@arendjr
Copy link
Contributor

arendjr commented Aug 12, 2022

Did you try 0.3.11 as well? I haven't tried that fix yet, so cannot vouch for it...

@arendjr
Copy link
Contributor

arendjr commented Aug 12, 2022

In any case, looking at the lock file, there's a whole bunch of wasm-bindgen stuff included. If you track down why they are included, you should find the culprit :)

@emschwartz
Copy link
Contributor Author

@arendjr same error with time@0.3.11

@arendjr arendjr merged commit f346d16 into main Aug 16, 2022
@arendjr arendjr deleted the move-providers branch August 16, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants