Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize DataSourceType as plain string #46

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

emschwartz
Copy link
Contributor

@emschwartz emschwartz commented Jan 11, 2022

Resolves FP-1046
Resolves FP-832

@emschwartz emschwartz requested a review from a team as a code owner January 11, 2022 16:53
@linear
Copy link

linear bot commented Jan 11, 2022

FP-1046 Make Relay DataSourceType match schema

The generated API client expects the dataSourceType to be a string but the Relay returns it as an enum

@emschwartz emschwartz requested a review from hatchan January 11, 2022 16:53
@emschwartz emschwartz force-pushed the fix_data_source_type branch from 0c11563 to df9fc69 Compare January 11, 2022 16:54
@linear
Copy link

linear bot commented Jan 11, 2022

FP-832 Relay api & schema are out-of-sync

Something changed recently in the output for the /api/proxies/datasources endpoint. The type property of the datasource is no longer type string as the schema says, but an object with a single type property.

This is caused by a change in the proxy_types for the DataSourceType enum. Which adds tag = "type" to the serde/macro. definition

@emschwartz emschwartz merged commit cd74dfd into main Jan 12, 2022
@emschwartz emschwartz deleted the fix_data_source_type branch January 12, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants