Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spin #659

Merged
merged 8 commits into from
May 26, 2023
Merged

Upgrade Spin #659

merged 8 commits into from
May 26, 2023

Conversation

tpmccallum
Copy link
Contributor

@tpmccallum tpmccallum commented May 22, 2023

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check
Screenshot 2023-05-26 at 2 47 22 pm
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
Screenshot 2023-05-26 at 2 47 50 pm
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
Screenshot 2023-05-26 at 2 51 34 pm
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
@tpmccallum
Copy link
Contributor Author

tpmccallum commented May 22, 2023

I have a question about system package installers.
Can we add brew and apt installation methods as additional content in the "/spin/install" page and then add the appropriate upgrade information on this page?

Related issues/discussions:
Installable via OS package managers spinframework/spin#641
Conditionally use Homebrew location for Spin plugins and templates spinframework/spin#1494
Use Normal Distribution Channels spinframework/spin#1490

@tpmccallum tpmccallum changed the title Adding first draft to prompt discussion Upgrade Spin: Adding first draft to prompt discussion May 22, 2023
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
@tpmccallum
Copy link
Contributor Author

Closes #653

tpmccallum and others added 6 commits May 23, 2023 13:49
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Co-authored-by: itowlson <github@hestia.cc>
Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Co-authored-by: itowlson <github@hestia.cc>
Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com

Co-authored-by: itowlson <github@hestia.cc>
Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
@tpmccallum tpmccallum requested a review from rajatjindal May 26, 2023 05:13
@tpmccallum tpmccallum merged commit 0798ace into fermyon:main May 26, 2023
@tpmccallum tpmccallum changed the title Upgrade Spin: Adding first draft to prompt discussion Upgrade Spin May 26, 2023
@tpmccallum tpmccallum deleted the upgrade_spin branch August 30, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants