-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding spin to path #193
adding spin to path #193
Conversation
Signed-off-by: MacKenzie Olson <48335676+macolso@users.noreply.github.com>
Added to |
I'm a little concerned with this as it might break a flow which is deliberately very hard to break. Not sure if everyone can run the I think the real way to solve this is through spinframework/spin#641 and then make the quickstart use those. |
Let me know if I'm too much of a chicken :-) |
Signed-off-by: MacKenzie Olson <48335676+macolso@users.noreply.github.com>
I'm aligned with that thought process - we may lose some users who don't have the ability to run I really like how Nomad's UI on their install options . We should do something like once spinframework/spin#641 is completed |
@tpmccallum ☝🏻 |
|
Signed-off-by: MacKenzie Olson <48335676+macolso@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handlebars
does not support multiline strings. Therefore the line breaks must be represented using \n
Co-authored-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com> Signed-off-by: MacKenzie Olson <48335676+macolso@users.noreply.github.com>
Going to hold off merging until we have a complete installation story |
Signed-off-by: MacKenzie Olson 48335676+macolso@users.noreply.github.com
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,
template, and
date` are all setcat -ve <filename> | grep '^M' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors